Skip to content

fix: treat errored chat sessions as disconnected#1245

Open
lopes-felipe wants to merge 1 commit intopingdotgg:mainfrom
lopes-felipe:fix/chat-session-error-phase
Open

fix: treat errored chat sessions as disconnected#1245
lopes-felipe wants to merge 1 commit intopingdotgg:mainfrom
lopes-felipe:fix/chat-session-error-phase

Conversation

@lopes-felipe
Copy link

@lopes-felipe lopes-felipe commented Mar 20, 2026 •
edited by macroscopeapp bot
Loading

What Changed

  • Updated derivePhase() in the web app to treat session.status === "error" as "disconnected" instead of "ready"
  • Added a regression test covering the errored-session case

Why

The chat UI was treating provider/runtime failures as a normal ready state because errored sessions fell through the phase mapping. That left the composer in regular ready-state UI after a session failure.

Mapping errored sessions to "disconnected" keeps the chat view aligned with the actual backend session state and avoids presenting a failed thread as ready for normal interaction.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Fix derivePhase to return 'disconnected' for errored chat sessions

Previously, derivePhase in session-logic.ts only returned 'disconnected' for null or 'closed' sessions, so sessions with status: 'error' incorrectly returned 'ready'. The fix adds 'error' to the disconnected condition, matching it with the null/closed cases.

Macroscope summarized 6b6d83e.

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7f9d5191-4109-40c4-9d7d-bbae5372d968

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lopes-felipe